From 7b34c5c9ba9b59c0086297bd714c878d6f2a0d2d Mon Sep 17 00:00:00 2001 From: Nathan Cannon Date: Thu, 25 Jul 2019 15:16:52 +0100 Subject: [PATCH] Linter conformance --- .../controller/GroupSessionController.kt | 2 +- .../controller/ObservationsController.kt | 6 +- frontend/src/App.vue | 48 +- frontend/src/components/ObservationEntry.vue | 4 +- .../src/components/ObservationSearchBar.vue | 20 +- frontend/src/components/ScoreSelector.vue | 1 - frontend/src/router.js | 4 +- frontend/src/views/About.vue | 52 +- frontend/src/views/DatabaseUnavailable.vue | 47 +- frontend/src/views/GroupSession.vue | 88 ++- frontend/src/views/GroupSessionInput.vue | 99 ++- frontend/src/views/Home.vue | 73 +- frontend/src/views/NewSite.vue | 70 +- frontend/src/views/NewTutor.vue | 30 +- frontend/src/views/Observation.vue | 674 ++++++++++++------ frontend/src/views/ObservationComplete.vue | 17 +- frontend/src/views/StartNew.vue | 169 +++-- frontend/src/views/Stats.vue | 177 +++-- frontend/src/views/ViewObservations.vue | 172 +++-- 19 files changed, 1137 insertions(+), 616 deletions(-) diff --git a/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/GroupSessionController.kt b/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/GroupSessionController.kt index bf8b674..83e4e25 100644 --- a/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/GroupSessionController.kt +++ b/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/GroupSessionController.kt @@ -178,7 +178,7 @@ class GroupSessionController { observations.add(observation) } GroupSessionManager.invalidate() - if(this::environment.isInitialized && environment.getProperty("smtp.autosendoncomplete")!!.toBoolean()) + if (this::environment.isInitialized && environment.getProperty("smtp.autosendoncomplete")!!.toBoolean()) GlobalScope.launch { if (::mailer.isInitialized) mailer.sendObservationData(observations) diff --git a/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/ObservationsController.kt b/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/ObservationsController.kt index e66ccd6..1d95d04 100644 --- a/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/ObservationsController.kt +++ b/backend/src/main/kotlin/uk/co/neviyn/observationdatabase/controller/ObservationsController.kt @@ -54,7 +54,6 @@ class ObservationsController { @Autowired lateinit var mailer: Email - /** * Returns a list of all current sites. */ @@ -285,12 +284,11 @@ class ObservationsController { logger.info("Sending Observation data by email") if (::mailer.isInitialized) { val data = getObservations(observationsRequest) - if(data.isEmpty()) + if (data.isEmpty()) return false mailer.sendObservationData(data) return true - } - else + } else logger.error("Mailer has not been initialized.") return false } diff --git a/frontend/src/App.vue b/frontend/src/App.vue index 1797ee3..368cd28 100644 --- a/frontend/src/App.vue +++ b/frontend/src/App.vue @@ -1,28 +1,28 @@ diff --git a/frontend/src/components/ObservationEntry.vue b/frontend/src/components/ObservationEntry.vue index 5f3c072..2009b0b 100644 --- a/frontend/src/components/ObservationEntry.vue +++ b/frontend/src/components/ObservationEntry.vue @@ -3,7 +3,9 @@

{{ description }}

-

{{ scenariofundamental.rating }}

+

+ {{ scenariofundamental.rating }} +

- + - + - + @@ -156,7 +168,7 @@ export default { this.$refs.errorModal.show(); }); this.getTutors(); - this.$emit('refresh'); + this.$emit("refresh"); } }; diff --git a/frontend/src/components/ScoreSelector.vue b/frontend/src/components/ScoreSelector.vue index 40fb029..4c1f630 100644 --- a/frontend/src/components/ScoreSelector.vue +++ b/frontend/src/components/ScoreSelector.vue @@ -33,7 +33,6 @@ export default { }; - diff --git a/frontend/src/views/ObservationComplete.vue b/frontend/src/views/ObservationComplete.vue index ed467c4..807d0f4 100644 --- a/frontend/src/views/ObservationComplete.vue +++ b/frontend/src/views/ObservationComplete.vue @@ -1,11 +1,11 @@ - + diff --git a/frontend/src/views/StartNew.vue b/frontend/src/views/StartNew.vue index edb1dae..f577461 100644 --- a/frontend/src/views/StartNew.vue +++ b/frontend/src/views/StartNew.vue @@ -1,73 +1,98 @@